[FFmpeg-devel] [PATCH] avfilter: add motion filter

Moritz Barsnick barsnick at gmx.net
Thu Jul 13 16:59:59 EEST 2017


On Thu, Jul 13, 2017 at 15:34:26 +0200, Nicolas George wrote:
> > +static inline double get_motion_avg(double motion_sum, uint64_t nb_frames)
> > +{
> > +    return motion_sum / nb_frames;
> > +}
> 
> Is it really useful as a separate function?

It's the same style as in all the previous filters submitted by Ashish,
BTW. (Just saying, no judgment.)

> > +    if (!(s->ref_data = av_malloc(data_sz))) {
> > +        av_log(ctx, AV_LOG_ERROR, "ref_buf allocation failed.\n");
> 
> > +        return AVERROR(EINVAL);
> 
> The correct return code would be ENOMEM.

Ditto. I had noticed but wasn't sure, and didn't have anything else to
say. I'm just saying, the learnings from these remarks can be taken for
the other filters an well.

Moritz


More information about the ffmpeg-devel mailing list