[FFmpeg-devel] Question on the “decode_failed” logic in ffmpeg.c:

[Steven Liu]

2017-07-12 12:32 GMT+08:00 Geek.Song <ffmpeg at gmail.com>:
> In ffmpeg.c:
> //
> // @ static int process_input_packet(InputStream *ist, const AVPacket
> *pkt, int no_eof)
> //
>  if (ret < 0) {
>             if (decode_failed) {
>                 av_log(NULL, AV_LOG_ERROR, "Error while decoding
> stream #%d:%d: %s\n",
>                        ist->file_index, ist->st->index, av_err2str(ret));
>             } else {
>                 av_log(NULL, AV_LOG_FATAL, "Error while processing the decoded "
>                        "data for stream #%d:%d\n", ist->file_index,
> ist->st->index);
>             }
>             if (!decode_failed || exit_on_error)
>                 exit_program(1);
>             break;
> }
>
>
> why is:
> if (!decode_failed || exit_on_error)
>     exit_program(1);
>
> I think it should be:
If it should be :if (decode_failed || exit_on_error)
maybe only if (exit_on_error) than that, isn't it?
> if (decode_failed || exit_on_error)
>     exit_program(1);
>
>
> -----------------------------------------
> Productive. Reliable. Fast.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel