[FFmpeg-devel] [PATCH] pthread_frame: save the FF_DEBUG_THREADS option in FrameThreadContext.

Wan-Teh Chang wtc at google.com
Sat Jul 8 00:30:00 EEST 2017


Note: I suspect we can simply delete the following line from
update_context_from_user() in libavcodec/pthread_frame.c:

    dst->debug    = src->debug;

That also fixes the tsan warning, but it'll take more time to
investigate whether it is necessary to update the |debug| field from
the user's AVCodecContext (src).

That line in update_context_from_user() was added in the initial
commit of libavcodec/pthread.c:

http://git.videolan.org/?p=ffmpeg.git;a=commit;h=37b00b47cbeecd66bb34c5c7c534d016d6e8da24

Does any user actually modify avctx->debug after the avcodec_open2() call?

Thanks,
Wan-Teh Chang


More information about the ffmpeg-devel mailing list