[FFmpeg-devel] [PATCH] avfilter: add VMAF filter

[Derek Buitenhuis]

On 7/3/2017 5:38 PM, Ashish Singh wrote:
> +enabled libvmaf           && { check_lib libvmaf "libvmaf.h" "compute_vmaf" -lvmaf -lstdc++ -lpthread -lm ||
> +                               die "ERROR: libvmaf must be installed"; }

This won't work on, for example, OS X, which uses libc++ instead of libstdc++.
It'll also add extra unneeded libs to the linker flags when libvmaf is built
as a hared library,

The correct solution is for libvmaf to provide a proper pkg-config file.

> +    {"disable avx",  "Disables avx for computing vmaf.",            OFFSET(disable_avx), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS},

Erm, why is this a user option?

[...]

At a glace am I correct in thinking that all this locking around calls is because
libvmaf is not thread-safe?

- Derek