[FFmpeg-devel] [PATCH]lavf/mov: Ignore avio_skip() return value

wm4 nfxjfg at googlemail.com
Thu Jan 26 07:27:42 EET 2017


On Thu, 26 Jan 2017 00:34:20 +0100
Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> From 694daed9222e50d6245bf5d041e82523ee869451 Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <cehoyos at ag.or.at>
> Date: Thu, 26 Jan 2017 00:32:23 +0100
> Subject: [PATCH] lavf/mov: Ignore avio_skip() return value.
> 
> Fixes ticket #6102.
> ---
>  libavformat/mov.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 7dc550e..6f7e80a 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -4794,9 +4794,7 @@ static int mov_read_uuid(MOVContext *c, AVIOContext *pb, MOVAtom atom)
>              av_free(buffer);
>          } else {
>              // skip all uuid atom, which makes it fast for long uuid-xmp file
> -            ret = avio_skip(pb, len);
> -            if (ret < 0)
> -                return ret;
> +            avio_skip(pb, len);
>          }
>      } else if (!memcmp(uuid, uuid_spherical, sizeof(uuid))) {
>          size_t len = atom.size - sizeof(uuid);

Why would you just ignore the error?


More information about the ffmpeg-devel mailing list