[FFmpeg-devel] [PATCH 1/2] avfilter/ebur128: do not allow null ebur128 context in ff_ebur128_relative_threshold

Marton Balint cus at passwd.hu
Wed Jan 25 02:57:24 EET 2017


The user should supply a proper context.

Fixes Coverity CID 1396246.

Signed-off-by: Marton Balint <cus at passwd.hu>
---
 libavfilter/ebur128.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/ebur128.c b/libavfilter/ebur128.c
index a46692e..012df54 100644
--- a/libavfilter/ebur128.c
+++ b/libavfilter/ebur128.c
@@ -599,7 +599,7 @@ int ff_ebur128_relative_threshold(FFEBUR128State * st, double *out)
     double relative_threshold;
     size_t above_thresh_counter;
 
-    if (st && (st->mode & FF_EBUR128_MODE_I) != FF_EBUR128_MODE_I)
+    if ((st->mode & FF_EBUR128_MODE_I) != FF_EBUR128_MODE_I)
         return AVERROR(EINVAL);
 
     ebur128_calc_relative_threshold(st, &above_thresh_counter,
-- 
2.10.2



More information about the ffmpeg-devel mailing list