[FFmpeg-devel] [PATCHv3] add signature filter for MPEG7 video signature

[Moritz Barsnick]

On Tue, Jan 03, 2017 at 16:29:44 +0100, Gerion Entrup wrote:
> The matching is not calculated automatically but with a commandline switch. I've tried
> to reformulate it in a better way.

Very good, I understand it now. :-)

> I don't understand fully what your question is.
> 
> The output path is either a standard filepath or (if muliple inputs exist) similar to
> the path specification in other parts of FFmpeg (e.g. the image2 muxer).

Forget it, I believe this is only relevant to libavformat. (Background
is that, using internal av_*() functions, you can handle input and
output "files" as arbitrary URLs, with whatever libavformat supports:
file:, ftp://, and so on. You can't use this code in libavfilter
though, I believe.)

> > The English opposite of "fine" is "coarse", not "course". :)
> Oops.

You still have a few "courses". (The actual variables, not the types. I
don't care *too* much, but might be better for consistency.)

> Done in most cases.

Perfect.

> Thank you for the suggestions. Attached the new patch and diff to the last patch.
(Thanks for the diff-diff.)

>From my side - mostly style and docs - it looks fine. Technically, I
can't judge too much. You went through a long review cycle already, so
I assume it's fine for those previous reviewers. They have the last
call anyway.

Gruß,
Moritz