[FFmpeg-devel] [PATCH] avdevice/decklink: Remove pthread dependency
zeranoe at gmail.com
Thu Feb 23 02:13:16 EET 2017
On Wed, Feb 22, 2017 at 6:55 PM, Marton Balint <cus at passwd.hu> wrote:
> On Wed, 22 Feb 2017, Kyle Schwarz wrote:
>> DeckLink depends on pthread, and is silently disabled if pthread is
>> Also fixes w32pthreads to support C++.
> You should split this into two patches, one the w32pthreads C++ support,
> other the decklink patch.
Would it be best to resubmit as two new threads for both, or simply
split and reply to this thread?
> Also, I checked the decklink part, and I am a bit confused. I don't see how
> you ensure that ctx->frames_buffer number of frames are scheduled. Also, are
> you sure you use the condition/mutexes properly? Your code does not even
> contains a pthread_mutex_lock call, that seems odd.
> What I would expect is to protect the scheduled frame counter with a mutex,
> and do a cond_signal in the scheduled frame completed callback. Or do you
> have something else in mind?
I'm not terribly familiar with mutex and pthread, so you're probably right.
I'll look into your suggestions and come up with a revision.
More information about the ffmpeg-devel