[FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

[Ronald S. Bultje]

Hi,

On Tue, Feb 21, 2017 at 6:22 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com>
wrote:

> 2017-02-21 12:21 GMT+01:00 Paul B Mahol <onemda at gmail.com>:
> > On 2/21/17, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> >> 2017-02-21 12:07 GMT+01:00 Paul B Mahol <onemda at gmail.com>:
> >>> On 2/21/17, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> >>>> 2017-02-21 10:59 GMT+01:00 Paul B Mahol <onemda at gmail.com>:
> >>>>> Fixes #1849.
> >>>>
> >>>> The patch changes output for the sample from ticket #1848, is
> >>>> this intended?
> >>>
> >>> Yes.
> >>
> >> Reference decoder output sounds very different here - more
> >> similar without the patch applied.
> >
> > Similar is not good enough.
>
> I don't disagree I just thought that worse isn't better.


For the rest of us, this isn't helpful. What differences are you seeing?
Can you send a before/after sine wave diagram to showcase relevant
differences? Or something else that isn't just "it's better!" vs. "it's
worse" without any relevant explanation of what you're talking about.

(This is a reply to both, not just Carl.)

Ronald