[FFmpeg-devel] [PATCH] fate/source: Check for cases that could use av_clip_uintp2() and av_clip_intp2()

[Michael Niedermayer]

On Mon, Feb 20, 2017 at 12:34:36PM +0100, Clément Bœsch wrote:
> On Fri, Feb 17, 2017 at 01:59:08AM +0100, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  tests/fate/source-check.sh | 14 ++++++++++++++
> >  tests/ref/fate/source      |  2 ++
> >  2 files changed, 16 insertions(+)
> > 
> > diff --git a/tests/fate/source-check.sh b/tests/fate/source-check.sh
> > index ac2878d9f7..72e1511f0d 100755
> > --- a/tests/fate/source-check.sh
> > +++ b/tests/fate/source-check.sh
> > @@ -30,4 +30,18 @@ for f in `git ls-files | grep '\.h$'` ; do
> >      grep -L "^#define $macro$" $f
> >  done
> >  
> 
> > +echo "Use of av_clip() where av_clip_uintp2 could be used:"
> 
> the use of () is not consistent

fixed


> 
> > +git grep -E 'av_clip *\(.*, *0 *, *(3|7|15|31|63|127|255|511|1023|2047|4095|8191|'\
> > +'16383|32767|65535|131071|262143|524287|1048575|2097151|4194303|8388607|16777215|'\
> > +'33554431|67108863|134217727|268435455|536870911|1073741823) *\)' | grep -v fate/source
> > +
> > +echo "Use of av_clip() where av_clip_intp2 could be used:"
> > +git grep -E 'av_clip *\(.*, *(-2 *, *1|-4 *, *3|-8 *, *7|-16 *, *15|-32 *, *31|-64'\
> > +' *, *63|-128 *, *127|-256 *, *255|-512 *, *511|-1024 *, *1023|-2048 *, *2047|-4096'\
> > +' *, *4095|-8192 *, *8191|-16384 *, *16383|-32768 *, *32767|-65536 *, *65535|-131072'\
> > +' *, *131071|-262144 *, *262143|-524288 *, *524287|-1048576 *, *1048575|-2097152 *,'\
> > +' *2097151|-4194304 *, *4194303|-8388608 *, *8388607|-16777216 *, *16777215|-33554432'\
> > +' *, *33554431|-67108864 *, *67108863|-134217728 *, *134217727|-268435456 *, *'\
> > +'268435455|-536870912 *, *536870911|-1073741824 *, *1073741823) *\)'| grep -v fate/source
> > +
> 
> you could add support for the 0x forms:
> 
> libavcodec/g726.c:    return av_clip(re_signal << 2, -0xffff, 0xffff);

-0xffff is not one of the supported cases of av_clip_intp2

will apply this patchset with my next push

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170220/81e70139/attachment.sig>