[FFmpeg-devel] [PATCH] rv34dsp: Exclude mmx for x86_64 at build time

Carl Eugen Hoyos ceffmpeg at gmail.com
Fri Feb 17 13:02:10 EET 2017


2017-02-17 11:56 GMT+01:00 Hugo Beauzée-Luyssen <hugo at beauzee.fr>:
> On Fri, Feb 17, 2017, at 11:50 AM, Carl Eugen Hoyos wrote:
>> 2017-02-17 11:24 GMT+01:00 Hugo Beauzée-Luyssen <hugo at beauzee.fr>:
>> > The function is not defined when building for x86_64
>>
>> But it is declared unconditionally.
>>
>> How can the issue you are trying to fix be reproduced?
>> Why is this the only occurrence?
>>
>> Carl Eugen
>
> Hi,
>
> This problem arose while building VLC for Android-x86_64.

How can we reproduce the issue?

> I'm quite convinced there is a similar issue for VP8, but we don't use
> that module in our builds.

You also disable huffyuv?

> It could be a good idea to conditionally declare the function as well
> indeed.

I would prefer not to add more conditionals to the files and I wonder
why this issue triggers only in this file for you - dead code elimination
is needed in many places when compiling FFmpeg.

Carl Eugen


More information about the ffmpeg-devel mailing list