[FFmpeg-devel] [PATCH] lavc: consider an error during decoder draining as EOF

[Michael Niedermayer]

On Wed, Feb 15, 2017 at 08:53:18AM +0100, wm4 wrote:
> There is no reason that draining couldn't return an error or two. But
> some decoders don't handle this very well, and might always return an
> error. This can lead to API users getting into an infinite loop and
> burning CPU, because no progress is made and EOF is never returned.
> 
> In fact, ffmpeg.c contains a hack against such a case. It is removed
> with this patch. This particular error case seems to have been fixed
> since the hack was added, though.
> 
> This might lose frames if decoding returns errors during draining.
> ---
>  ffmpeg.c           | 6 ------
>  libavcodec/utils.c | 6 +++---
>  2 files changed, 3 insertions(+), 9 deletions(-)

should be 2 patches, libavcodec one should bump minor version
"new" ffmpeg depends on the change (new version) otherwise it could get
stuck

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170215/d09063c7/attachment.sig>