[FFmpeg-devel] [PATCH] avformat/hlsenc: set default http method to PUT when method is null

Moritz Barsnick barsnick at gmx.net
Wed Feb 15 22:59:44 EET 2017


On Wed, Feb 15, 2017 at 23:45:49 +0800, Steven Liu wrote:
> +        proto = avio_find_protocol_name(hls->basename);
> +        if (hls->method || (proto && !av_strcasecmp(proto, "http"))) {

Would this also need to apply to https? (I'm not sure whether those
protocols are distinguished.)

> +        av_log(c, AV_LOG_WARNING, "You forget set http method, hls muxer auto set default method to PUT\n");

"No HTTP method set, hls muxer defaulting to method PUT.\n"

(If you actually want to keep the original sentence: "You forget to set
http method, hls muxer automatically set default method to PUT\n". I
would avoid the use of "you"...)

Moritz


More information about the ffmpeg-devel mailing list