[FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

Timo Rothenpieler timo at rothenpieler.org
Sun Feb 12 21:52:02 EET 2017


On 2/12/2017 8:43 PM, Miroslav SlugeĊˆ wrote:
> Dne 12.2.2017 v 20:29 Timo Rothenpieler napsal(a):
>> The current behavior is intended like it is.
>> On the default of -1, it does not care about I/IDR frame requests, in
>> mode 0 it will generate intra frames, and in mode 1 it will generate
>> full IDR frames.
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> This is not clever, because i checked both libx264 and libx265 and both
> of them has same behavior like i proposed in patch.
> 
> Also explanation of this function is than wrong:
> { "forced-idr",   "If forcing keyframes, force them as IDR frames."}
> 
> There is nothing about disabled forcing keyframes at all.
> 
> So we have two options:
> 1. We should change it in NVENC
> or
> 2. We should change it in libx264 and libx265

Changing it in nvenc now would be kind of an API break, as the behaviour
might change without someone expecting it.


More information about the ffmpeg-devel mailing list