[FFmpeg-devel] [PATCH 1/3] libavcodec/cinepakenc.c: comments cleanup (contents)

Michael Niedermayer michael at niedermayer.cc
Tue Feb 7 23:50:42 EET 2017

On Tue, Feb 07, 2017 at 12:54:02PM +0100, u-9iep at aetey.se wrote:
> Hello Michael,
> On Tue, Feb 07, 2017 at 03:09:56AM +0100, Michael Niedermayer wrote:
> > > What about the other patches from that series?
> > 
> > > The second one is purely cosmetic (looks useful to me but not much
> > > of concern)
> > 
> > I have no oppinion about // vs /**/ comments but in the absence of
> > a reason to change them my gut feeling leans toward leaving things
> > as they are for "git blame" simplification.
> No objection.
> > > while the third (tiny) one is about correcting an inverted
> > > explanation in a comment.
> > 
> > I think the 3rd depends on the 2nd
> No, the third is standalone.
> It was possibly wrong to put them in the same series, but otherwise a
> confusion would be probably easy, too.
> > another point which was brought up by jb on IRC and in RL longer ago
> > was that ideally the author field in git should contain a name.
> > It may help with contacting one in the far future or with simply
> > refering to the author as in

> > who wrote the cinepack optimizations?
> > Author: addr-see-the-website at aetey.se <addr-see-the-website at aetey.se>
> Contact data is not identity even though this fact is ignored in some
> widely spread (misled) practices, which the above example illustrates
> well. There are actually two separate questions:
> Q: Who wrote the cinepak optimizations?
> A: A person known as Rl @ Aetey Global Technologies AB.

There is no "Rl" in there

git removes that when applying with git am
git am
From: Rl <addr-see-the-website at aetey.se>
git show
Author: addr-see-the-website at aetey.se <addr-see-the-website at aetey.se>

I dont know why git does that but it does, i retested this as it seemed
rather unexpected and odd

I can manually override this and force git to use Rl as name so i
will do that, but this may be error prone if git fails to keep Rl
even after there are commits in the tree with that name.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170207/2e6815de/attachment.sig>

More information about the ffmpeg-devel mailing list