[FFmpeg-devel] [PATCH 1/3] libavcodec/cinepakenc.c: comments cleanup (contents)

Michael Niedermayer michael at niedermayer.cc
Tue Feb 7 04:09:56 EET 2017

On Mon, Feb 06, 2017 at 10:51:30AM +0100, u-9iep at aetey.se wrote:
> On Thu, Feb 02, 2017 at 05:19:16PM +0100, Michael Niedermayer wrote:
> > On Thu, Feb 02, 2017 at 04:22:28PM +0100, u-9iep at aetey.se wrote:
> > > On Thu, Feb 02, 2017 at 01:31:00PM +0100, Michael Niedermayer wrote:
> > patch applied
> > 
> > thx
> Thanks Michael.
> What about the other patches from that series?

> The second one is purely cosmetic (looks useful to me but not much
> of concern)

I have no oppinion about // vs /**/ comments but in the absence of
a reason to change them my gut feeling leans toward leaving things
as they are for "git blame" simplification.

A reason would be consistency or the preferrance of the people
working on the code or maintaining it or the authors preferrance, ...

> while the third (tiny) one is about correcting an inverted
> explanation in a comment.

I think the 3rd depends on the 2nd

another point which was brought up by jb on IRC and in RL longer ago
was that ideally the author field in git should contain a name.

It may help with contacting one in the far future or with simply
refering to the author as in
who wrote the cinepack optimizations?
Author: addr-see-the-website at aetey.se <addr-see-the-website at aetey.se>
is a bit cumbersome but its not mine to judge that. If you want
that in the author field, thats ok as far as iam concerned, i just
have difficulty imagening that being intended over a pronouncable
name (even if thats a pseudonym) before <addr-see-the-website at aetey.se>


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170207/1b0b3117/attachment.sig>

More information about the ffmpeg-devel mailing list