[FFmpeg-devel] [PATCH] Cinepak: speed up decoding several-fold, depending on the scenario, by supporting multiple output pixel formats.

Clément Bœsch u at pkh.me
Tue Feb 7 00:05:06 EET 2017


On Mon, Feb 06, 2017 at 10:05:10AM +0100, u-9iep at aetey.se wrote:
[...]
> > No, code quality is not outside the scope of your patch.
> 
> Code quality is a subjective matter.
> 

I'm not going to fight with you: several developers consider your patch
does not pass the quality requirements of the project. It's arbitrary,
subjective, unfair, or even wrong if you want, but that's the current
policy of the project. Changing that policy is outside the scope of this
patch.

[...]
> > The use of the environment variable is not tolerable, this is a blocker.
> 
> It is explicitly specified that it is _not_ being used,

Then please drop the dead code.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170206/8706c38d/attachment.sig>


More information about the ffmpeg-devel mailing list