[FFmpeg-devel] [PATCH] avfilter: add deconvolve filter

[Tomas Härdin]

mån 2017-12-25 klockan 21:38 +0100 skrev Paul B Mahol:
> > 
> -        if (!(s->fft_hdata[i] = av_calloc(s->fft_len[i] + 1, s->fft_len[i] * sizeof(FFTComplex))))
> +        if (!(s->fft_hdata[i] = av_calloc(s->fft_len[i], s->fft_len[i] * sizeof(FFTComplex))))
>              return AVERROR(ENOMEM);
>  

Is there a particular reason these were +1? Maybe something to do with
padding?

> @@ -166,7 +171,7 @@ static int fft_horizontal(AVFilterContext *ctx, void *arg, int jobnr, int nb_job
>      FFTComplex *hdata = td->hdata;
>      const int plane = td->plane;
>      const int n = td->n;
> -    int start = (n *  jobnr   ) / nb_jobs;
> +    int start = (n * jobnr) / nb_jobs;

Don't mix cosmetic and functional changes

Rest of the patch looks OK enough to me

/Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171226/9117b71a/attachment.sig>