[FFmpeg-devel] [PATCH 07/14] mediacodec: check whether cropping is set before use

[Matthieu Bouron]

On Sat, Dec 16, 2017 at 07:20:53PM +0800, Wang Bin wrote:
> 2017-12-16 17:12 GMT+08:00 Matthieu Bouron <matthieu.bouron at gmail.com>:
> > On Sat, Dec 16, 2017 at 01:40:18PM +0800, Wang Bin wrote:
> >> > > +        width = s->crop_right + 1 - s->crop_left;
> >> > > +    else
> >> > > +        width = s->width;
> >> > >
> >> > >      av_log(avctx, AV_LOG_INFO,
> >> > >          "Output crop parameters top=%d bottom=%d left=%d right=%d, "
> >> >
> >> > On which device does this happen ?
> >>
> >>
> >> None of my devices have such problem. It happens if replace jni by ndk
> >> mediacodec functions(maybe another patch later). original code:
> >> https://github.com/aosp-mirror/platform_frameworks_base/blob/master/media/java/android/media/MediaCodec.java#L190
> >
> > OK. I will soon apply the patch.
> >
> > I'm however not in favor of replacing the MediaCodec jni code by its ndk
> > counterpart now as it would drop compatibility with Android 4.4.
> 
> Just load libmediandk.so and resolve symbols at runtime, and fallback
> to jni if the library does not exist, i.e. on android < 5.0

I don't really want to maintain both code paths as it will add complexity.
If we are to use the ndk I would also prefer to link against the library
directly instead of loading its symbols at runtime.

Note: I'm not against switching to the NDK in the future as it would allow
us to remove the jni dependency, but it's a bit too early IMHO.

-- 
Matthieu B.