[FFmpeg-devel] [PATCH v3 1/3] avformat/mxfenc: use track count to generate component instance uuid

[Tomas Härdin]

On Thu, 2017-12-07 at 22:40 +0100, Michael Niedermayer wrote:
> On Thu, Dec 07, 2017 at 04:41:09PM +0100, Tomas Härdin wrote:
> > On 2017-12-05 05:46, Mark Reid wrote:
> > > @@ -1398,16 +1397,26 @@ static void
> > > mxf_write_package(AVFormatContext *s, MXFPackage *package)
> > >              mxf_write_uuid(pb, SubDescriptor, 0);
> > >      }
> > > +    /*
> > > +     * for every 1 track in a package there is 1 sequence and 1
> > > component.
> > > +     * all 3 of these elements share the same instance number
> > > for generating
> > > +     * there instance uuids. mxf->track_instance_count stores
> > > this value.
> > > +     * mxf->track_instance_count is incremented after a group of
> > > all 3 of
> > > +     * these elements are written.
> > > +     */
> > > +
> > 
> > Excellent.
> > 
> > Patch looks good to me :)
> 
> any reason why you didnt apply it ?

No access. Plus waiting for feedback on my other comment

/Tomas