[FFmpeg-devel] [PATCH v3 2/3] avformat/mxfenc: write reel_name if metadata key is present

[Tomas Härdin]

On 2017-12-05 05:46, Mark Reid wrote:
> ---
>   libavformat/mxf.h    |  1 +
>   libavformat/mxfenc.c | 42 +++++++++++++++++++++++++++++++++++-------
>   2 files changed, 36 insertions(+), 7 deletions(-)
>
>
> @@ -1476,6 +1495,15 @@ static int mxf_write_header_metadata_sets(AVFormatContext *s)
>           }
>       }
>   
> +    entry = av_dict_get(s->metadata, "reel_name", NULL, 0);
> +    if (entry) {
> +        packages[2].name = entry->value;
> +        packages[2].type = SourcePackage;
> +        packages[2].instance = 2;
> +        packages[1].ref = &packages[2];
> +        package_count = 3;
> +    }

I guess we can have it check track metadata later if we feel like it. 
Did a patch moving reel_name into AVFormatContext make it into mxfdec 
yet? mxfenc's output surviving a roundtrip through mxfdec + mxfenc might 
be desirable:

     ffmpeg -i somefile_with_reel_name.mkv output.mxf
     ffmpeg -i output.mxf -vcodec copy -acodec copy remuxed.mxf

Ideally remuxed.mxf is identical to output.mxf

/Tomas