[FFmpeg-devel] [PATCH] avfilter/formats: fix wrong function name in error message

Hendrik Leppkes h.leppkes at gmail.com
Mon Dec 4 12:07:11 EET 2017


On Mon, Dec 4, 2017 at 10:53 AM, Moritz Barsnick <barsnick at gmx.net> wrote:
> On Mon, Dec 04, 2017 at 13:02:20 +0800, Jun Zhao wrote:
>> Use perdefined micro __FUNCTION__ rather than hard coding function name
>> to fix wrong function name in error message.
>
> AFAICT, "__FUNCTION__" is a C99 feature and thereby not supported by
> ffmpeg style. Or should it be? (It might be "supported by all compilers
> we care about".)
>
> http://ffmpeg.org/developer.html#C-language-features
>

__FUNCTION__ is not C99, its a compiler extension (which is understood
by GCC and some other compilers). __func__ is the C99 keyword.
Its likely that not all compilers we currently support would have
__func__, if they all have __FUNCTION__ however I cannot tell.

- Hendrik


More information about the ffmpeg-devel mailing list