[FFmpeg-devel] [PATCH] libavcodec/dvbsubdec: Fix for ticket 6796 (ffprobe show_frames ts dvbsubs infinite loop)

Moritz Barsnick barsnick at gmx.net
Mon Dec 4 11:48:47 EET 2017


On Mon, Dec 04, 2017 at 02:54:13 +0000, Colin NG wrote:

> libavcodec/dvbsubdec: Fix for ticket 6796 (ffprobe show_frames ts dvbsubs infinite loop)

Same comment as to the other patch's commit message.

Furthermore: Didn't the other patch already claim to fix #6796? If not,
you need to say "partially fixes".

That said:

>  static int dvbsub_decode(AVCodecContext *avctx,
> -                         void *data, int *data_size,
> +                         void *data, int *got_output,
>                           AVPacket *avpkt)

Do I see it correctly that you are only renaming one variable? Then
please say so in the commit message, and don't claim that it fixes
anything.

Moritz


More information about the ffmpeg-devel mailing list