[FFmpeg-devel] [PATCH] avfilter: add ADM filter

[Nicolas George]

Le quartidi 14 fructidor, an CCXXV, Ashish Pratap Singh a écrit :
> From: Ashish Singh <ashk43712 at gmail.com>
> 
> Hi,
> This patch changes adm filter from dualinput to framesync2.
> 
> Signed-off-by: Ashish Singh <ashk43712 at gmail.com>
> ---
>  Changelog                |   1 +
>  doc/filters.texi         |  15 +
>  libavfilter/Makefile     |   1 +

>  libavfilter/adm.h        |  75 +++++

Can you explain the rationale for a separate header?

As far as I can see, you are declaring static variables in it, which is
almost always wrong, and a function that is only used once and could be
static (and if not, needs the ff_ namespace).

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170831/bcd03a9c/attachment.sig>