[FFmpeg-devel] [PATCH v17] avformat/dashdec: add dash demuxer base version

Timo Rothenpieler timo at rothenpieler.org
Wed Aug 30 12:43:04 EEST 2017


> v16 fixed:
> 1. remove the snprintf and instead by get_segment_filename make safety
> 2. remove unnecessary loops
> 3. updated xmlStrcmp and xmlFree to av_* functions
> 4. merge code repeat into one function
> 5. add memory alloc faild check
> 6. update update_init_section and open_url
> 7. output safety error message when filename template not safe
> Suggested-by : wm4 <nfxjfg at googlemail.com>
> 
> v17 fixed:
> 1. add memory alloc faild check
> 2. fix resource space error at free_representation
> 
> Signed-off-by: Steven Liu <lq at chinaffmpeg.org>
> Signed-off-by: samsamsam <samsamsam at o2.pl>

Just wanted to point out, as stated on IRC, that dashenc already has a 
function that seems to safely solve the filename template issue, and 
looks like it can be moved into a common file + header, and reused as is:

http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavformat/dashenc.c;h=bdb332c71ab4aae87201c87c3d43938a07a9ed5c;hb=HEAD#l314

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3994 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170830/1ae976e2/attachment.bin>


More information about the ffmpeg-devel mailing list