[FFmpeg-devel] [PATCH 3/3] avformat/mxfenc: Replace literal numbers by named enum values.

Александр Слободенюк alexander.slobodeniuk at bramtech.ru
Wed Aug 30 12:19:54 EEST 2017


Piece of code:

cid = header_cid[0] << 24 | header_cid[1] << 16 | header_cid[2] << 8 | header_cid[3];
..
switch (cid) {
    case 1235:

.. is platform related, isn't it? It seems to me, that it shouldn't work on BE machine.

> On Tue, Aug 29, 2017 at 02:13:21AM +0200, Michael Niedermayer wrote:
>> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
>> ---
>>  libavformat/mxfenc.c | 83 ++++++++++++++++++++++++++++++++++++++--------------
>>  1 file changed, 61 insertions(+), 22 deletions(-)

> applied

> [...]



-- 
С уважением,
 Александр                          mailto:alexander.slobodeniuk at bramtech.ru



More information about the ffmpeg-devel mailing list