[FFmpeg-devel] [PATCH 0/2] Tile threading support for vp9

[Michael Niedermayer]

On Mon, Aug 28, 2017 at 02:22:15AM +0700, Ilia Valiakhmetov wrote:
> These patches introduce tile threading support for vp9.
> 
> Tile threading is ~45% faster at 2 threads vs 1.
> Frame threading is ~55% faster at 2 threads vs 1.
> ffvp9 tile threading is ~25% faster than libvpx-vp9 at 2 threads
> 
> execute3() function is similar to execute2(), execept it has
> a extra argument - main function for avpriv_slicethread_create(), it is used for the loopfilter.
> 
> Ilia Valiakhmetov (2):
>   avcodec: add execute3() api to utilize the main function of
>     avpriv_slicethread_create().
>   avcodec/vp9: Add tile threading support

this seems to break build with mips-linux-gnu-gcc-4.4 and --disable-pthreads

In file included from src/libavcodec/vp9data.h:28,
                 from src/libavcodec/vp9.c:33:
src/libavcodec/vp9dec.h:218: error: redefinition of typedef ‘VP9TileData’
src/libavcodec/vp9dec.h:89: note: previous declaration of ‘VP9TileData’ was here
src/libavcodec/vp9.c: In function ‘vp9_free_entries’:
src/libavcodec/vp9.c:115: error: implicit declaration of function ‘pthread_mutex_destroy’
src/libavcodec/vp9.c:116: error: implicit declaration of function ‘pthread_cond_destroy’
src/libavcodec/vp9.c: In function ‘vp9_alloc_entries’:
src/libavcodec/vp9.c:138: error: implicit declaration of function ‘pthread_mutex_init’
src/libavcodec/vp9.c:139: error: implicit declaration of function ‘pthread_cond_init’
src/libavcodec/vp9.c: In function ‘vp9_report_tile_progress’:
src/libavcodec/vp9.c:146: error: implicit declaration of function ‘pthread_cond_signal’
src/libavcodec/vp9.c: In function ‘vp9_await_tile_progress’:
src/libavcodec/vp9.c:153: error: implicit declaration of function ‘pthread_mutex_lock’
src/libavcodec/vp9.c:155: error: implicit declaration of function ‘pthread_cond_wait’
src/libavcodec/vp9.c:156: error: implicit declaration of function ‘pthread_mutex_unlock’
src/libavcodec/vp9.c: In function ‘vp9_decode_frame’:
src/libavcodec/vp9.c:1424: warning: ‘pkt_pts’ is deprecated (declared at src/libavutil/frame.h:302)
make: *** [libavcodec/vp9.o] Error 1
make: *** Waiting for unfinished jobs....

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who would give up essential Liberty, to purchase a little
temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170828/ae9d5642/attachment.sig>