[FFmpeg-devel] [PATCH] avcodec/imgconvert: remove deprecation guards for a function that's not declared as such

James Almer jamrial at gmail.com
Fri Aug 25 17:04:25 EEST 2017


On 8/25/2017 8:10 AM, Ronald S. Bultje wrote:
> Hi,
> 
> On Thu, Aug 24, 2017 at 7:43 PM, James Almer <jamrial at gmail.com> wrote:
> 
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> The deprecation seems to have been imported from libav but never made
>> effective.
> 
> 
> Hm, but do we really want this function? Shouldn't all users be ported to
> the function this wraps?

I don't know. The Doxy even acknowledges there's an alternative but
mentions its use case is apparently different, which is probably why
the deprecation wasn't made effective.

If the function really needs to go, then the deprecated attribute should
be added to the header. And from that point the ~2 years deprecation
period starts.

> 
> Ronald
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 



More information about the ffmpeg-devel mailing list