[FFmpeg-devel] [PATCH] avcodec/mjpegenc: disable unused code with AMV

Michael Niedermayer michael at niedermayer.cc
Thu Aug 10 04:27:55 EEST 2017


On Wed, Aug 09, 2017 at 07:46:30AM +0000, Davinder Singh wrote:
> hi,
> 
> this disables unused function amv_encode_picture() when AMV encoder is
> disabled (and mjpeg enabled).
> silences this warning:
> CC libavcodec/mjpegenc.o
> libavcodec/mjpegenc.c:351:12: warning: unused function 'amv_encode_picture'
> [-Wunused-function]
> static int amv_encode_picture(AVCodecContext *avctx, AVPacket *pkt,
>            ^
> 
> Patch attached.
> 
> Regards.
> -- 
> Davinder Singh

>  mjpegenc.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 0fe583bfdb304ce3d8881e9836cc1983c65e3a90  0001-avcodec-mjpegenc-disable-unused-code-with-AMV.patch
> From cadf679bb0ad6d09d451512238e790645262f2f8 Mon Sep 17 00:00:00 2001
> From: Davinder Singh <ds.mudhar at gmail.com>
> Date: Wed, 9 Aug 2017 13:01:07 +0530
> Subject: [PATCH] avcodec/mjpegenc: disable unused code with AMV
> 
> disable unused amv_encode_picture() when AMV encoder is not configured.
> minor formatting improvement.
> ---
>  libavcodec/mjpegenc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/libavcodec/mjpegenc.c b/libavcodec/mjpegenc.c
> index ee77cde8cb..e6cdaf6376 100644
> --- a/libavcodec/mjpegenc.c
> +++ b/libavcodec/mjpegenc.c
> @@ -39,7 +39,6 @@
>  #include "mjpeg.h"
>  #include "mjpegenc.h"
>  
> -
>  static int alloc_huffman(MpegEncContext *s)
>  {
>      MJpegContext *m = s->mjpeg_ctx;

please move  unrelated cosmetic chages into a seperate patch

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170810/2d04928d/attachment.sig>


More information about the ffmpeg-devel mailing list