[FFmpeg-devel] [PATCH] avformat/utils: fix memory leak in avformat_free_context

[Steven Siloti]

On Mon, Jul 31, 2017 at 11:08 AM, Steven Siloti <ssiloti at bittorrent.com>
wrote:

> The pointer to the packet queue is stored in the internal structure
> so the queue needs to be flushed before internal is freed.
>
> Signed-off-by: Steven Siloti <ssiloti at bittorrent.com>
> ---
>  libavformat/utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/utils.c b/libavformat/utils.c
> index 38d247c6cd..58283616dc 100644
> --- a/libavformat/utils.c
> +++ b/libavformat/utils.c
> @@ -4333,8 +4333,8 @@ void avformat_free_context(AVFormatContext *s)
>      av_dict_free(&s->metadata);
>      av_dict_free(&s->internal->id3v2_meta);
>      av_freep(&s->streams);
> -    av_freep(&s->internal);
>      flush_packet_queue(s);
> +    av_freep(&s->internal);
>      av_free(s);
>  }
>
> --
> 2.13.0.windows.1
>
> Is there something wrong with this patch? It seems like a straightforward
fix to me. Perhaps you would prefer it as an attachment. If so, attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avformat-utils-fix-memory-leak-in-avformat_free_cont.patch
Type: application/octet-stream
Size: 939 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170803/e0a29464/attachment.obj>