[FFmpeg-devel] [PATCHv2 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

Hendrik Leppkes h.leppkes at gmail.com
Wed Aug 2 10:33:04 EEST 2017


On Tue, Aug 1, 2017 at 2:54 PM, Jorge Ramirez-Ortiz
<jorge.ramirez-ortiz at linaro.org> wrote:
> From: Alexis Ballier <aballier at gentoo.org>
>
> This patchset enhances Alexis Ballier's original patch and validates
> it using Qualcomm's Venus hardware (driver recently landed upstream
> [1]).
>
> This has been tested on Qualcomm's DragonBoard 410c and 820c
>
> Tested decoders:
>        - h264
>        - mpeg4
>        - vp8
>        - vp9
>        - hevc
>
> Tested encoders:
>        -h264
>        -h263
>        -mpeg4
>
> Tested transcoding (concurrent encoding/decoding)
>
> Some of the changes introduced:
> - v4l2: code cleanup.
> - v4l2: follow the decode api.
> - v4l2: fix display size for NV12 output pool.
> - v4l2: handle EOS.
> - v4l2: vp8 and mpeg4 decoding.
> - v4l2: hevc and vp9 support.
> - v4l2: generate EOF on dequeue errors.
> - v4l2: h264_mp4toannexb filtering.
> - v4l2: import compat/v4l2 header files.
>
> [1] https://lwn.net/Articles/697956/
>
> Reviewed-by: Jorge Ramirez <jorge.ramirez-ortiz at linaro.org>
> Reviewed-by: Alexis Ballier <aballier at gentoo.org>
> Tested-by: Jorge Ramirez <jorge.ramirez-ortiz at linaro.org>
> ---
>  Changelog                     |    3 +-
>  compat/v4l2/v4l2-common.h     |  107 ++
>  compat/v4l2/v4l2-controls.h   |  987 +++++++++++++++++
>  compat/v4l2/videodev2.h       | 2402 +++++++++++++++++++++++++++++++++++++++++

As commented on IRC before, I'm not a fan of importing Linux kernel
headers for the only reason because its convenient to always have
recent headers available.
On a system with a recent enough kernel to run this, you would also
have matching headers, so IMHO this should behave like any external
library dependency and just check that the headers are recent enough
to build our code, and just skip building the module otherwise.

- Hendrik


More information about the ffmpeg-devel mailing list