[FFmpeg-devel] [PATCH 1/2] webmdashenc: Require the 'adaptation_sets' option to be ste

[Derek Buitenhuis]

On 4/20/2017 4:58 PM, James Almer wrote:
> EINVAL IMO, since it's an user option.

AVERROR_INVALIDDATA was defined as AVERROR(EINVAL) for years, I guess
I forgot it changed to something else...

git blame puts it at 72af5d8a020e4dca1118b3ede67be983b33e27c5 in 2010...
My memory was seriously outdated.

I can change it before push, or however pushes it can change it.

> A non-optional user setting that has no default is in any case weird.
> Usually, the user expects a ffmpeg -i INPUT OUTPUT to work even if the 
> result is of low quality.

I find it odd too, but the entire concept of the webm_dash_manifest "demuxer"
and "muxer" is odd/hacky, so I didn't think about it too much, or I'd have made
myself sad.

- Derek