[FFmpeg-devel] [PATCH] this is the gsos qualification task which use psychoacoustic system to detect transients in vorbis encoder.

[Michael Niedermayer]

On Sun, Apr 16, 2017 at 10:23:05PM -0400, 汲如意 wrote:
> Hi, I am sorry for my mistakes. I have fixed them. And attachment is the
> patch which fix error in first one. Thanks.

this segfaults

make fate-vorbis-encode

ffmpeg  -i fate-suite//audio-reference/luckynight_2ch_44kHz_s16.wav -c:a vorbis -strict experimental -f ogg -y vorbis-encode.ogg

also please send complete patches and not a patch + a bugfix on top of
it

==30596== Conditional jump or move depends on uninitialised value(s)
==30596==    at 0xF3736B: ff_psy_init (psymodel.c:59)
==30596==    by 0xBBAFFD: vorbis_encode_init (vorbisenc.c:1250)
==30596==    by 0xB61BC5: avcodec_open2 (utils.c:1001)
==30596==    by 0x43695D: init_output_stream (ffmpeg.c:3427)
==30596==    by 0x42E562: reap_filters (ffmpeg.c:1441)
==30596==    by 0x43ACAA: transcode_step (ffmpeg.c:4511)
==30596==    by 0x43AD8E: transcode (ffmpeg.c:4555)
==30596==    by 0x43B563: main (ffmpeg.c:4760)
==30596==
==30596== Invalid write of size 8
==30596==    at 0xF3732A: ff_psy_init (psymodel.c:60)
==30596==    by 0xBBAFFD: vorbis_encode_init (vorbisenc.c:1250)
==30596==    by 0xB61BC5: avcodec_open2 (utils.c:1001)
==30596==    by 0x43695D: init_output_stream (ffmpeg.c:3427)
==30596==    by 0x42E562: reap_filters (ffmpeg.c:1441)
==30596==    by 0x43ACAA: transcode_step (ffmpeg.c:4511)
==30596==    by 0x43AD8E: transcode (ffmpeg.c:4555)
==30596==    by 0x43B563: main (ffmpeg.c:4760)
==30596==  Address 0x108c1508 is 0 bytes after a block of size 296 alloc'd
==30596==    at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
==30596==    by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
==30596==    by 0x10C17CB: av_malloc (mem.c:87)
==30596==    by 0x10C1A73: av_mallocz (mem.c:224)
==30596==    by 0xF3713B: av_mallocz_array (mem.h:233)
==30596==    by 0xF371A3: ff_psy_init (psymodel.c:39)
==30596==    by 0xBBAFFD: vorbis_encode_init (vorbisenc.c:1250)
==30596==    by 0xB61BC5: avcodec_open2 (utils.c:1001)
==30596==    by 0x43695D: init_output_stream (ffmpeg.c:3427)
==30596==    by 0x42E562: reap_filters (ffmpeg.c:1441)
==30596==    by 0x43ACAA: transcode_step (ffmpeg.c:4511)
==30596==    by 0x43AD8E: transcode (ffmpeg.c:4555)
==30596==
--30596-- VALGRIND INTERNAL ERROR: Valgrind received a signal 11 (SIGSEGV) - exiting
--30596-- si_code=1;  Faulting address: 0x211ADB50;  sp: 0x4046efd50


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170419/806a3b35/attachment.sig>