[FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency

[Hendrik Leppkes]

On Thu, Apr 13, 2017 at 10:36 AM, Aaron Levinson <alevinsn at aracnet.com> wrote:
> On 4/13/2017 1:21 AM, Hendrik Leppkes wrote:
>>
>> On Thu, Apr 13, 2017 at 5:32 AM, Aaron Levinson <alevinsn at aracnet.com>
>> wrote:
>>>
>>> diff --git a/configure b/configure
>>> index b0f7b1a..adb0060 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -2992,9 +2992,9 @@ avfoundation_indev_deps="pthreads"
>>>  avfoundation_indev_extralibs="-framework Foundation -framework
>>> AVFoundation -framework CoreVideo -framework CoreMedia"
>>>  bktr_indev_deps_any="dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h
>>> dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h"
>>>  caca_outdev_deps="libcaca"
>>> -decklink_indev_deps="decklink pthreads"
>>> +decklink_indev_deps="decklink"
>>>  decklink_indev_extralibs="-lstdc++"
>>> -decklink_outdev_deps="decklink pthreads"
>>> +decklink_outdev_deps="decklink"
>>
>>
>> You should probably still have a dependency on "threads" (a combined
>> dep for any threading support), or does the device work without any
>> threading support now?
>
>
> That makes sense, and I think I follow how the threads dependency is
> generated in configure.  Should I generate an entirely new patch?  The only
> difference would be the following, assuming all is okay with the actual code
> changes:
>

Give it some time for the other changes to be reviewed by the people
that actually know decklink itself, you can include that in any new
versions of the patch then, no need to send one for that right now.

- Hendrik