[FFmpeg-devel] [PATCH 1/6] idct_arm: remove use of ff_put/add_pixels_clamped function pointer.

Ronald S. Bultje rsbultje at gmail.com
Wed Apr 5 00:47:38 EEST 2017


Hi,

On Tue, Apr 4, 2017 at 5:18 PM, Michael Niedermayer <michael at niedermayer.cc>
wrote:

> On Tue, Apr 04, 2017 at 12:48:13PM -0400, Ronald S. Bultje wrote:
> > Instead, hardcode the use of the _arm implementation of this function.
> > Since there's separate implementations of idct{,_put,_add} for neon,
> > this has no practical effect on performance.
> > ---
> >  libavcodec/arm/idctdsp_init_arm.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
>
> fails to build here
>
> src/libavcodec/arm/idctdsp_init_arm.c: In function ‘j_rev_dct_arm_put’:
> src/libavcodec/arm/idctdsp_init_arm.c:42:5: error: implicit declaration
> of function ‘ff_put_pixels_clamped_arm’
> make: *** [libavcodec/arm/idctdsp_init_arm.o] Error 1


Crap I misread the code. New version sent that I (compile-)tested.

Ronald


More information about the ffmpeg-devel mailing list