[FFmpeg-devel] [PATCH] idctdsp: make ff_add/put_pixels_clamped function pointers atomic.

[Michael Niedermayer]

On Tue, Apr 04, 2017 at 09:09:36AM -0400, Ronald S. Bultje wrote:
> This fixes the following tsan warnings when running fate-dnxhr-parse:
> 
> WARNING: ThreadSanitizer: data race (pid=29917)
>   Write of size 8 at 0x0000025b12d8 by thread T2 (mutexes: write M1543):
>     #0 ff_idctdsp_init src/libavcodec/idctdsp.c:313 (ffmpeg+0x00000044b68e)
> [..]
>   Previous write of size 8 at 0x0000025b12d8 by thread T1 (mutexes: write M1541):
>     #0 ff_idctdsp_init src/libavcodec/idctdsp.c:313 (ffmpeg+0x00000044b68e)
> ---
>  libavcodec/idctdsp.c |  8 ++++----
>  libavcodec/idctdsp.h | 17 +++++++++++++++--
>  2 files changed, 19 insertions(+), 6 deletions(-)

does this have any performance effect and why do 2 threads write into
the same variable ?
It seems rather suspicious that 2 diferent threads write into the same
pointer


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170404/fe4428d8/attachment.sig>