[FFmpeg-devel] [PATCH] png: split header state and data state in two separate variables.

Michael Niedermayer michael at niedermayer.cc
Mon Apr 3 19:40:14 EEST 2017


On Mon, Apr 03, 2017 at 10:09:30AM -0400, Ronald S. Bultje wrote:
> Fixes a reported (but false) race condition in tsan for fate-apng:
> 
> WARNING: ThreadSanitizer: data race (pid=6274)
>   Read of size 4 at 0x7d680001ec78 by main thread (mutexes: write M1338):
>     #0 update_thread_context src/libavcodec/pngdec.c:1456 (ffmpeg+0x000000dacf0c)
> [..]
>   Previous write of size 4 at 0x7d680001ec78 by thread T1 (mutexes: write M1335):
>     #0 decode_idat_chunk src/libavcodec/pngdec.c:737 (ffmpeg+0x000000dae951)
> ---
>  libavcodec/png.h    |  5 -----
>  libavcodec/pngdec.c | 65 ++++++++++++++++++++++++++++++++---------------------
>  2 files changed, 39 insertions(+), 31 deletions(-)

the patch looks good to me

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170403/e054a691/attachment.sig>


More information about the ffmpeg-devel mailing list