[FFmpeg-devel] [PATCH v12] avformat/dashdec: add dash demuxer base version

[Michael Niedermayer]

On Sat, Apr 01, 2017 at 03:28:37PM +0200, wm4 wrote:
> On Sat, 1 Apr 2017 15:20:22 +0200
> Nicolas George <george at nsup.org> wrote:
> 
> > Le duodi 12 germinal, an CCXXV, Steven Liu a écrit :
> > > oops, sorry, the reviewer name add by the members who have reply mail, if
> > > you don't like to review this patch, i will remove your reviewed-by, sorry.  
> > 
> > I intend to review this patch as much as my time permits before it moves
> > forward. My name can be added to the list if and when that happens. I
> > suspect it applies to several people in the list; "reviewed-by" does not
> > mean they made a few comments on the patch, it actually means they read
> > the whole thing carefully and found no severe problem.
> > 
> > Also, I notice you replied only to half the points I made in my previous
> > mail. Possibly you did not see the other due to a faulty mail client, or
> > maybe you just did not have anything to reply to it. I would like to
> > confirm either way.
> 
> How is he supposed to know when it has been "reviewed" by you?

People should litterally reply with

Reviewed-by: ...
when it has been reviewed
on a line by its own in a review, this is also picked up by patchwork
and the patch review count updated accordingly

almost noone does that though, i did it in the past but failed to
spread the trend
so it can be hard, yes you are correct


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170401/5134f3f7/attachment.sig>