[FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

[wm4]

On Fri, 30 Sep 2016 00:21:56 +0200
Michael Niedermayer <michael at niedermayer.cc> wrote:

> On Thu, Sep 29, 2016 at 09:54:42PM +0100, Josh de Kock wrote:
> > There is really no need for two aac wrappers, we already have
> > libfdk-aac which is better. Not to mention that faac doesn't
> > even support HEv1, or HEv2. It's also under a license which is
> > unusable for distribution, so it would only be useful to people
> > who will compile their own ffmpeg, only use it themselves (which
> > at that point should just use fdk-aac).
> > 
> > Signed-off-by: Josh de Kock <josh at itanimul.li>
> > ---
> >  Changelog              |   1 +
> >  LICENSE.md             |   2 -
> >  configure              |   6 --
> >  doc/encoders.texi      | 105 ---------------------
> >  doc/ffserver.conf      |   2 +-
> >  doc/general.texi       |   2 +-
> >  doc/muxers.texi        |   4 +-
> >  doc/platform.texi      |   2 +-
> >  libavcodec/Makefile    |   1 -
> >  libavcodec/allcodecs.c |   1 -
> >  libavcodec/libfaac.c   | 248 -------------------------------------------------
> >  11 files changed, 6 insertions(+), 368 deletions(-)
> >  delete mode 100644 libavcodec/libfaac.c  
> 
> dont remember if it was specific to libfaac but some issues in the
> mov edit list patches about initial padding and trailing padding
> where found using libfaac as encoder.

Just because it was useful in one situation doesn't mean we have to
keep it forever. Also this argument is highly shady and unspecific. Why
couldn't this done with another encoder? What are the details on this?

> if libfaac support is droped, muxers wont be tested against it anymore
> most likely. It could be done with command line faac and remuxing but
> that special case makes it so unwieldy that i doubt anyone will do it

I highly doubt anyone will bother with installing and compiling with
libfaac at all.

> also quite some testcases in trac tickets used libfaac as it was
> default at the time,
> regression testing future changes against these tickets may be
> unreliable without libfaac

Well good thing that we don't have to fix libfaac bugs anymore once
this is removed.

What is the real reason you want to keep this? Last time you argued
libfaac was needed for audio encoding on phones, even though absolutely
nobody is going to put ffmpeg+libfaac into an "app" because of license
problems.