[FFmpeg-devel] [PATCH 1/2] lavf/mxfdec: add support for all of the picture size and offset fields

Carl Eugen Hoyos ceffmpeg at gmail.com
Mon Sep 26 09:29:44 EEST 2016

2016-09-26 1:52 GMT+02:00 Jan Ekström <jeebjp at gmail.com>:
> * Renames the `width` and `height` entries to `stored_{width,height}`
>   according to the specification's naming.

This should be a separate patch. (Although I wonder how useful it is:
Are you planning to add yourself as mxf maintainer? This would be
very welcome.)

> * Switches the data type of widths and heights to uint32_t according
>   to specification, adds additional checks to make sure we don't
>   overflow INT_MAX as codecpar->{width,height} are signed integers.

If this fixes anything (I am not sure I understand: Are you changing a
type which introduces a possible undefined behaviour, so you add an
additional check at the same time?) it should be part of above new
patch imo (or an independent patch).

> * Adds and parses the sampled and display width and height entries.

The rest should be added together with the side data injection.

Carl Eugen

More information about the ffmpeg-devel mailing list