[FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

[Michael Fritscher]

Hi,

I try to build ffmpeg 3.1.3 on cygwin64 on Windows.

Configstring: ./configure --prefix=/usr/local --enable-ffplay 
--enable-ffmpeg --enable-ffserver --enable-gpl --enable-version3 
--enable-nonfree --enable-shared --enable-libfreetype --enable-libgsm 
--enable-libmp3lame --enable-libopencv --enable-libtheora 
--enable-libvorbis --enable-libx264 --enable-libxvid --enable-ffplay 
--enable-outdev=sdl --enable-outdev=xv --enable-indev=dshow 
--enable-pthreads --enable-ffplay --enable-ffmpeg --enable-ffserver 
--enable-demuxer=mpegvideo --enable-parser=mpegvideo 
--enable-muxer=mpjpeg --enable-muxer=mjpeg --enable-demuxer=mjpeg 
--enable-parser=mjpeg

Output:
CC      cmdutils.o
cmdutils.c: In Funktion »init_dynload«:
cmdutils.c:115:5: Fehler: Implizite Deklaration der Funktion 
»SetDllDirectory« [-Werror=implicit-function-declaration]
       SetDllDirectory("");

My quick fix was to add

#if HAVE_SETDLLDIRECTORY
#include <windows.h>
#endif

on line 64. Is this the right way to cope with this? At least it 
compiles, links and works ;-)

In current git I found
#ifdef _WIN32
#include <windows.h>
#endif,

which does not work under cygwin. Apparently _WIN32 is not defined in 
this environment.

Best regards,
Michael Fritscher
-- 
ZfT - Zentrum für Telematik e.V.
Michael Fritscher
Magdalene-Schoch-Straße 5
97074 Würzburg
Tel: +49 (931) 615 633 - 57
Fax: +49 (931) 615 633 - 11
Email: michael.fritscher at telematik-zentrum.de
Web: http://www.telematik-zentrum.de

Vorstand:
Prof. Dr. Klaus Schilling, Hans-Joachim Leistner
Sitz: Gerbrunn
USt.-ID Nr.: DE 257 244 580, Steuer-Nr.:  257/111/70203
Amtsgericht Würzburg, Vereinsregister-Nr.: VR 200 167

-------------- next part --------------
A non-text attachment was scrubbed...
Name: michael_fritscher.vcf
Type: text/x-vcard
Size: 340 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160922/a8abd512/attachment.vcf>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4423 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160922/a8abd512/attachment.bin>