[FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

[Paul B Mahol]

On 9/19/16, Paul B Mahol <onemda at gmail.com> wrote:
> On 9/19/16, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> 2016-09-19 14:02 GMT+02:00 Clement Boesch <u at pkh.me>:
>>> On Mon, Sep 19, 2016 at 01:32:54PM +0200, Carl Eugen Hoyos wrote:
>>>> Hi!
>>>>
>>>> Attached patch fixes the aspect ratio for the sample from
>>>> ticket #5325 / #2125.
>>>>
>>>> The fate test changes because the fate sample  was written
>>>> by FFmpeg with an incorrect aspect ratio.
>>>>
>>>> Please comment, Carl Eugen
>>>
>>>> From 0553b0adfee87401854f0313dbcf386f2fb7ae68 Mon Sep 17 00:00:00 2001
>>>> From: Carl Eugen Hoyos <cehoyos at ag.or.at>
>>>> Date: Mon, 19 Sep 2016 13:30:06 +0200
>>>> Subject: [PATCH] lavf/mov: Read aspect ratio from ares atom for dnxhd.
>>>>
>>>
>>>> Fixes ticket #2125.
>>>> Fixes ticket #5325.
>>>
>>> It fixes aspect ratio from samples from these tickets, it looks
>>> unrelated
>>> to the original issue.
>>
>> We seem to have very different interpretations of "unrelated" but changed
>> locally to "Fixes aspect ratio of sample in ticket ...."
>
> Maybe this patch with above locally changed text is correct.
>
> But it does change nothing with sample from ticket #5325. As that sample
> have same sar as before this patch.
>
> So it is another lie.
>

Ignore that one above, patck with corrected text is ok.