[FFmpeg-devel] [PATCH v2 2/4] ffplay: make copy for SDL1

Josh de Kock josh at itanimul.li
Thu Sep 15 13:19:54 EEST 2016


On 15/09/2016 10:58, Carl Eugen Hoyos wrote:
> 2016-09-15 10:39 GMT+02:00 Josh de Kock <josh at itanimul.li>:
>> Signed-off-by: Josh de Kock <josh at itanimul.li>
>> ---
>>  Makefile                  | 1 +
>>  ffplay.c                  | 5 +++++
>>  ffplay.c => ffplay_sdl1.c | 0
>>  3 files changed, 6 insertions(+)
>>  copy ffplay.c => ffplay_sdl1.c (100%)
>
>> diff --git a/ffplay.c b/ffplay.c
>> index adbe9cb..67a17e0 100644
>> --- a/ffplay.c
>> +++ b/ffplay.c
>> @@ -24,6 +24,9 @@
>>   */
>>
>>  #include "config.h"
>> +
>> +#if HAVE_SDL2
>
> Sorry if this should be obvious:
> What is the effect of this #if?
>
Don't worry, it's not really that obvious. If HAVE_SDL2 is false but 
HAVE_SDL is true, then ffplay.c will get macro'd out, and ffplay_sdl1.c 
will get added to the ffplay sources (see the Makefile change). If you 
can think of a better way to do it, feel free to suggest.

--
Josh



More information about the ffmpeg-devel mailing list