[FFmpeg-devel] [PATCH] fate/als: add floating point decoding test

[Michael Niedermayer]

On Sun, Jul 17, 2016 at 07:25:31PM +0530, Umair Khan wrote:
> On Sun, Jul 17, 2016 at 1:50 PM, Thilo Borgmann <thilo.borgmann at mail.de> wrote:
> > Hi,
> >
> >> From e172e333807b4b3b2558a1ffa735ade79a3f3e36 Mon Sep 17 00:00:00 2001
> >> From: Umair Khan <omerjerk at gmail.com>
> >> Date: Sun, 17 Jul 2016 13:05:49 +0530
> >> Subject: [PATCH 1/1] fate/als: add floating point decoding test
> >>
> >> Signed-off-by: Umair Khan <omerjerk at gmail.com>
> >> ---
> >>  tests/fate/als.mak | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/tests/fate/als.mak b/tests/fate/als.mak
> >> index ff2badf..2847a8d 100644
> >> --- a/tests/fate/als.mak
> >> +++ b/tests/fate/als.mak
> >> @@ -7,5 +7,8 @@ endef
> >>
> >>  $(foreach N,$(ALS_SUITE),$(eval $(call FATE_ALS_SUITE,$(N))))
> >>
> >> ++FATE_ALS += fate-mpeg4-als-conformance-07
> >
> > Just add "07" to the ALS_SUITE.
> >
> > You also need to add a new "tests/ref/fate/mpeg4-als-conformance-07"
> > file containing the correct CRC for that conformance file.
> >
> > Please setup a local FATE suite and test your patch before resubmitting.
> 
> Tested.
> Updated patch attached.
> 
> -Umair

>  fate/als.mak                      |    3 +++
>  ref/fate/mpeg4-als-conformance-07 |    1 +
>  2 files changed, 4 insertions(+)
> 1a677b6670ab1214c568ea495efd182a285dc6e3  0001-fate-als-add-floating-point-decoding-test.patch
> From 4295fc1a5f56d81e9b498bece4aed36197328763 Mon Sep 17 00:00:00 2001
> From: Umair Khan <omerjerk at gmail.com>
> Date: Sun, 17 Jul 2016 13:05:49 +0530
> Subject: [PATCH 1/1] fate/als: add floating point decoding test
> 
> Signed-off-by: Umair Khan <omerjerk at gmail.com>
> ---
>  tests/fate/als.mak                      | 3 +++
>  tests/ref/fate/mpeg4-als-conformance-07 | 1 +
>  2 files changed, 4 insertions(+)
>  create mode 100644 tests/ref/fate/mpeg4-als-conformance-07
> 
> diff --git a/tests/fate/als.mak b/tests/fate/als.mak
> index ff2badf..a67302c 100644
> --- a/tests/fate/als.mak
> +++ b/tests/fate/als.mak
> @@ -7,5 +7,8 @@ endef
>  
>  $(foreach N,$(ALS_SUITE),$(eval $(call FATE_ALS_SUITE,$(N))))
>  
> +FATE_ALS += fate-mpeg4-als-conformance-07
> +fate-mpeg4-als-conformance-07: CMD = crc -i $(TARGET_SAMPLES)/lossless-audio/als_07_2ch192k32bF.mp4

fails on arm

--- tests/ref/fate/mpeg4-als-conformance-07     2016-09-08 18:36:16.095167935 +0200
+++ tests/data/fate/mpeg4-als-conformance-07    2016-09-08 18:49:32.219184707 +0200
@@ -1 +1 @@
-CRC=0x01503df3
+CRC=0x81b53f05
Test mpeg4-als-conformance-07 failed. Look at tests/data/fate/mpeg4-als-conformance-07.err for details.
make: *** [fate-mpeg4-als-conformance-07] Error 1

interrestingly it does not fail on mips

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160908/deb28628/attachment.sig>