[FFmpeg-devel] [PATCH] doc/developer: Add patchwork mentioning to "patch submission checklist"

Michael Niedermayer michael at niedermayer.cc
Wed Sep 7 18:11:03 EEST 2016


On Wed, Sep 07, 2016 at 04:44:54PM +0200, Michael Niedermayer wrote:
> On Wed, Sep 07, 2016 at 04:39:54PM +0200, Michael Niedermayer wrote:
> > On Wed, Sep 07, 2016 at 07:19:00AM -0700, Jonathan Campbell wrote:
> > > On 09/07/2016 04:51 AM, Michael Niedermayer wrote:
> > > > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > > > ---
> > > >  doc/developer.texi | 6 ++++++
> > > >  1 file changed, 6 insertions(+)
> > > > 
> > > > diff --git a/doc/developer.texi b/doc/developer.texi
> > > > index 4d3a7ae..51e3da7 100644
> > > > --- a/doc/developer.texi
> > > > +++ b/doc/developer.texi
> > > > @@ -641,6 +641,12 @@ are notoriously left unchecked, which is a serious problem.
> > > >  @item
> > > >  Test your code with valgrind and or Address Sanitizer to ensure it's free
> > > >  of leaks, out of array accesses, etc.
> > > > +
> > > > + at item
> > > > +Check that your submitted patch shows up on @url{https://patchwork.ffmpeg.org}.
> > > > +Also make sure its status is updated, you can create an account and update it.
> > > > +If your patch is incorrectly or not listed in patchwork then it might be
> > > > +missed by developers using patchwork to find patches needing review or pushing.
> > > >  @end enumerate
> > > >  
> > > >  @section Patch review process
> > > > 
> > > 
> > > I only see one of the 4 patches for AC-3 consistent noise generation (the libavutil version bump) on the patchwork site. Can I assume the other three will make their way into the patchwork list when the time is right, or did I submit the patch wrong?
> > 
> > all 4 patches are there:
> > https://patchwork.ffmpeg.org/project/ffmpeg/list/?submitter=82&state=%2A&archive=both
> 
> in fact thats the 4 mails not the 4 patches from the last mail
> patchwork does not support multiple patches per mail AFAIK

and MUAs cant keep properly track of multiple patches per mail either
a mail is either read or unread or otherwise flagged somehow, so
patchwork is in fact not really worse than using a MUA here


[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160907/4f16de04/attachment.sig>


More information about the ffmpeg-devel mailing list