[FFmpeg-devel] [PATCH] lavf/matroskaenc: use mkv_check_tag_name consistently

Michael Niedermayer michael at niedermayer.cc
Wed Sep 7 01:19:55 EEST 2016


On Tue, Sep 06, 2016 at 05:13:52PM -0500, Rodger Combs wrote:
> Previously, we used a different list of checks when deciding whether to
> write a set of tags at all than we did when deciding whether to write an
> individual tag in the set. This resulted in sometimes writing an empty
> tag master and seekhead. Now we use mkv_check_tag_name everywhere, so
> if a dictionary is entirely composed of tags we skip, we don't write a
> tag master at all.
> 
> This affected the test file, since "language" was on one list but not
> the other, so we were writing an empty tag master there. The test hash
> is updated to reflect that change.
> ---
>  libavformat/matroskaenc.c | 10 +++++-----
>  tests/fate/matroska.mak   |  2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)

excelent commit message

LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160907/c908027a/attachment.sig>


More information about the ffmpeg-devel mailing list