[FFmpeg-devel] [PATCH 5/5] af_hdcd: tweak hdcd_analyze_prepare() a bit

[Burt P.]

On Tue, Sep 6, 2016 at 6:12 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> 2016-09-06 13:02 GMT+02:00 Burt P. <pburt0 at gmail.com>:
>> On Tue, Sep 6, 2016 at 5:22 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>> 2016-09-05 13:18 GMT+02:00 Burt P <pburt0 at gmail.com>:
>>>> * use the actual sample rate
>>>
>>> Is hdcd supposed to work for sample_rates
>>> different from 44100?
>>
>> As I understand it, yes. The PM Model 2 supported code
>> insertion at all CD and DVD-Audio sample rates, so:
>> 44.1, 48, 88.2, 96, 176.4, and 192 kHz.
>> If any DVD-Audio was ever actually released with HDCD
>> encoding, I do not know.
>
> Is there a test if the sample_rate is any of the above?
>

Right now, query_formats only accepts 44100. I don't have any higher
rate samples to test, I don't know if it is a good idea to just add
the other rates to the accepted list if I can't test the results.
In this patch, I took the opportunity to remove a hard-coded rate and
use one from the framework. I did the same in patch 4/5 in this set.
hdcd_reset() already uses a variable rate to set the cdt period. All
that is left is to make whatever changes to hdcd_envelope(), if any.
So, perhaps in the future it will be possible to support the higher
rates.

I don't have any HDCD-encoded DVD-Audio (or any DVD-Audio), and I also
don't have a PM Model Two to generate some. For now anyway, I can't
test it.

-- 
Burt