[FFmpeg-devel] dash encoder. Correct generated manifest for MPEG-DASH MPD Validator and calculate current bandwidth for eath chunk. Now works correctly with dash.sj

Carl Eugen Hoyos ceffmpeg at gmail.com
Tue Sep 6 13:26:49 EEST 2016


2016-09-05 12:47 GMT+02:00 Ligverd Haer <ligverd at r46.ru>:
> Create valide manifest.
> Calculate current bandwidth for eath chunk.
> Now works correctly with dash.sj

> -        avio_printf(out, "\t\t<AdaptationSet contentType=\"video\"
> segmentAlignment=\"true\" bitstreamSwitching=\"true\"");
> -        if (c->max_frame_rate.num && !c->ambiguous_frame_rate)
> -            avio_printf(out, " %s=\"%d/%d\"", (av_cmp_q(c->min_frame_rate,
> c->max_frame_rate) < 0) ? "maxFrameRate" : "frameRate",
> c->max_frame_rate.num, c->max_frame_rate.den);
> -        avio_printf(out, ">\n");
> +        avio_printf(out, "\t\t<AdaptationSet contentType=\"video\"
> segmentAlignment=\"true\" bitstreamSwitching=\"true\">\n");

This hunk is not ok because it is needlessly difficult to understand
what you are changing:
Leave the first ("AdaptionSet") and last ("\n") line unchanged -
unless I misread the patch.

Carl Eugen


More information about the ffmpeg-devel mailing list