[FFmpeg-devel] [PATCH]lavc/avpacket: Fix undefined behaviour, do not pass null pointer to memcpy()

Carl Eugen Hoyos cehoyos at ag.or.at
Sun Sep 4 22:15:47 EEST 2016


Hi!

Attached patch fixes ticket #5128.

Please comment, Carl Eugen
-------------- next part --------------
From a3dcd65c313e6b456fcb05915508d8d583c1840e Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <cehoyos at ag.or.at>
Date: Sun, 4 Sep 2016 21:11:02 +0200
Subject: [PATCH] lavc/avpacket: Fix undefined behaviour, do not pass a null
 pointer to memcpy().

Fixes ticket #5128.
---
 libavcodec/avpacket.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c
index 92186892..fa2844d 100644
--- a/libavcodec/avpacket.c
+++ b/libavcodec/avpacket.c
@@ -581,7 +581,8 @@ int av_packet_ref(AVPacket *dst, const AVPacket *src)
         ret = packet_alloc(&dst->buf, src->size);
         if (ret < 0)
             goto fail;
-        memcpy(dst->buf->data, src->data, src->size);
+        if (src->size)
+            memcpy(dst->buf->data, src->data, src->size);
 
         dst->data = dst->buf->data;
     } else {
-- 
1.7.10.4



More information about the ffmpeg-devel mailing list