[FFmpeg-devel] [PATCH]fate: Add a test for ticket #5805.

Michael Niedermayer michael at niedermayer.cc
Sun Sep 4 21:18:56 EEST 2016


On Sun, Sep 04, 2016 at 01:52:47PM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> 2016-09-04 13:44 GMT+02:00 Michael Niedermayer <michael at niedermayer.cc>:
> > the test you submitted adds:
> > +fate-jpg-jfif: CMD = framecrc -idct simple -i $(TARGET_SAMPLES)/jpg/12bpp.jpg
> >
> > that 12bpp sample is not eight bit
> 
> Lol, thanks for noticing!
> 
> New patch attached, is "-idct simple" necessary?
> 
> Carl Eugen

>  fate/image.mak    |    4 ++++
>  ref/fate/jpg-jfif |    6 ++++++
>  2 files changed, 10 insertions(+)
> 7877ac40860f578a8c95353de19dba0c5ad1e27f  0001-fate-Add-test-for-ticket-5805.patch
> From 79ca5df18623475572c1eaaea1c1047b27295dee Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <cehoyos at ag.or.at>
> Date: Sun, 4 Sep 2016 13:50:44 +0200
> Subject: [PATCH] fate: Add test for ticket #5805.

LGTM

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160904/7e52eeba/attachment.sig>


More information about the ffmpeg-devel mailing list